Support for PHI Recording#76
Merged
Adithyan-Dinesh-Trenser merged 2 commits intonightlyfrom Mar 10, 2026
Merged
Conversation
…le 'simplified' measurement tracking mode
Adithyan-Dinesh-Trenser
force-pushed
the
gradienthealth/create-and-add-phi-bounding-box-as-new-button-section
branch
from
48c06a3 to
1fe8ae0
Compare
chengke2442
reviewed
Mar 3, 2026
chengke2442
left a comment
chengke2442
left a comment
There was a problem hiding this comment.
Can you add a PR description here?
chengke2442
reviewed
Mar 3, 2026
| props: { | ||
| icon: 'tool-rectangle', | ||
| label: i18n.t('Buttons:PHIBoundingBox'), | ||
| tooltip: i18n.t('Buttons:PHI BoundingBox'), |
There was a problem hiding this comment.
This is not a typo. This is the viewer tooltip naming convention
chengke2442
reviewed
Mar 3, 2026
| @@ -70,6 +70,7 @@ function initDefaultToolGroup(extensionManager, toolGroupService, commandsManage | |||
| { toolName: toolNames.EllipticalROI }, | |||
| { toolName: toolNames.CircleROI }, | |||
There was a problem hiding this comment.
why there are two duplicated config here
There was a problem hiding this comment.
If the query is about the duplicate configs, it is for different toolGroups.
If the query is about the duplicate tools, then they are separate tools for drawing circles, ellipses, etc.
chengke2442
reviewed
Mar 3, 2026
| } | ||
| } | ||
|
|
||
| PHIBoundingBoxTool.toolName = 'PHIBoundingBox'; |
Adithyan-Dinesh-Trenser
changed the title
Author
Added description |
chengke2442
approved these changes
Mar 6, 2026
Adithyan-Dinesh-Trenser
deleted the
gradienthealth/create-and-add-phi-bounding-box-as-new-button-section
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for recording and persisting PHI bounding box coordinates while reviewing study/ series from the sheet.